Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump redux from 3.6.0 to 4.0.5 in /client-admin #395

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 1, 2020

Bumps redux from 3.6.0 to 4.0.5.

Release notes

Sourced from redux's releases.

v4.0.5

This release includes a memory leak fix, and a fix for removing reducers with replaceReducer and combineReducers.

There are also some TypeScript changes, which require version 3.5 or higher. This also removes our DeepPartial type, which wasn't intended to be a public API. If you need this type, you can find an equivalent of likely higher quality in the utility-types package.

Speaking of TypeScript, we are done with converting the code to TypeScript on master and are looking to get some TS improvements in before launching 5.0. If you're interested in helping, feel free to submit a PR with anything you'd like to contribute.

Changes

v4.0.4

This is a republish of 4.0.3 with an updated version of Babel to fix #3468

Changes

v4.0.3

This is a quick revert of a change to our typings that broke compatibility. Apologies for the problems.

Also, if you are experiencing type errors related to [Symbol.observable], please ensure you have the same version of redux installed for all your dependencies with npm ls redux.

Changes

  • Reverts the change to combineReducers' type parameters (#3467 by @timdorr)

v4.0.2

This is a very minor release with some nice improvements to our TypeScript type definitions. Enjoy!

Changes

v4.0.1

A very minor release. We've upgraded to Babel 7 internally and now provide a .mjs file which you can import cleanly into browsers that support ES modules natively. Enjoy!

Changes

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from colinmegill as a code owner July 1, 2020 19:46
@dependabot dependabot bot added dependencies Pull requests that update a dependency file 🔩 p:client-admin labels Jul 1, 2020
@patcon
Copy link
Contributor

patcon commented Jul 2, 2020

According to these release notes, Redux 4.x only supports IE11+. Is that good enough for client-admin, @colinmegill? (If we upgrade, then this kinda makes the decision for our IE support minimum version in #166 :)

(3.x of redux works down to IE8, which means we can't use 4.x for client-participation)

EDIT: Hm. Maaaaaby doesn't matter if we're using webpack...? reduxjs/redux#774 (comment)

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/client-admin/dev/redux-4.0.5 branch 3 times, most recently from c822b81 to 9e6b5d7 Compare July 30, 2020 18:49
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/client-admin/dev/redux-4.0.5 branch 2 times, most recently from ba13ace to 4bee9ad Compare July 31, 2020 04:35
@patcon patcon requested a review from a team July 31, 2020 16:17
@patcon patcon changed the title Bump redux from 3.6.0 to 4.0.5 in /client-admin build(deps): bump redux from 3.6.0 to 4.0.5 in /client-admin Aug 1, 2020
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/client-admin/dev/redux-4.0.5 branch 2 times, most recently from 10d66ec to 66be401 Compare August 1, 2020 04:25
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/client-admin/dev/redux-4.0.5 branch 3 times, most recently from 4e36ce8 to 342b95d Compare December 1, 2020 23:28
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/client-admin/dev/redux-4.0.5 branch from 342b95d to 88a83b7 Compare December 1, 2020 23:49
@metasoarous metasoarous merged commit 48b3d1c into dev Dec 2, 2020
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/client-admin/dev/redux-4.0.5 branch December 2, 2020 00:26
@metasoarous
Copy link
Member

metasoarous commented Dec 2, 2020

@patcon Thanks for catching & flagging the EI version support concern. Looking into this it does seem like this only affects folks using the pre-minified builds. You're correct that this doesn't affect us, given that we're doing our own minification via webpack and friends. Still, thanks for being on the lookout!

raulsperoni pushed a commit to proyectourgente/polis that referenced this pull request Sep 1, 2021
…arn/client-admin/dev/redux-4.0.5

build(deps): bump redux from 3.6.0 to 4.0.5 in /client-admin
raulsperoni pushed a commit to proyectourgente/polis that referenced this pull request Oct 26, 2021
…arn/client-admin/dev/redux-4.0.5

build(deps): bump redux from 3.6.0 to 4.0.5 in /client-admin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 chore dependencies Pull requests that update a dependency file 🔩 p:client-admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants